Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ACPI device scope link. #212

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Eathonhsu
Copy link
Contributor

@Eathonhsu Eathonhsu commented Feb 2, 2024

Description

Remove the ACPI device scope link.

Root cause:

If the system LPC device is not "PC00.LPC0", this SSDT is invaild.

It does not need to be put under any device scope, it just need an ASL device in the root path with all the required methods then the IPMI device will be initialized success and show up in device manager.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

IPMC2

Integration Instructions

N/A

Remove the ACPI device scope link.

Root cause:

If the system LPC device is not "PC00.LPC0", this SSDT is invaild.

It does not need to be put under any device scope, it just need an ASL device in the root path with all the required methods
then the IPMI device will be initialized success and show up in device manager.
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (289f31e) 25.80% compared to head (e13f23f) 25.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   25.80%   25.80%           
=======================================
  Files          44       44           
  Lines        3248     3248           
  Branches      271      271           
=======================================
  Hits          838      838           
  Misses       2404     2404           
  Partials        6        6           
Flag Coverage Δ
IpmiFeaturePkg 25.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcChen46
Copy link
Contributor

@cfernald , @apop5 , please take a look at this PR, thanks.

@apop5 apop5 requested review from cfernald and apop5 February 2, 2024 21:19
@apop5 apop5 merged commit f8ea2a6 into microsoft:main Feb 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants