-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MdePkg: Add Google Mock Protocol for SmmCommunication #1266
base: dev/202405
Are you sure you want to change the base?
MdePkg: Add Google Mock Protocol for SmmCommunication #1266
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1266 +/- ##
===========================================
Coverage 1.60% 1.60%
===========================================
Files 1379 1379
Lines 359694 359694
Branches 5524 5524
===========================================
Hits 5760 5760
Misses 353827 353827
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There has been a slight change in how google test mocks need to be created for protcols. The documentation update is in PR form for edk2: https://github.com/tianocore/edk2/pull/10608/files As an example please see the file MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockHash2.h in in the PR: Also, since we are trying to upstream these changese into EDK2 at the same time to prevent conflicts in the future, can you also open this PR into edk2? Please see the instructions in: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process |
PR of edk2: tianocore/edk2#10705 |
Description
Added MockSmmCommunication to be used by Googletests
How This Was Tested
Added MockSmmCommunication to GoogleTests and able to successfully include its functions
Integration Instructions
N/A