Skip to content

Conversation

@conniey
Copy link
Member

@conniey conniey commented Oct 8, 2025

What does this PR do?

  • Support multi-platform builds.
  • Use distroless image.

GitHub issue number?

#146 #302

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Comment on lines +9 to 10
COPY ${PUBLISH_DIR}/${TARGETOS}-${TARGETARCH}/dist/ /azuremcpserver/
WORKDIR /azuremcpserver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be easier to support by templating PUBLISH_DIR with os and arch outside of the docker build call... we should also just assume PUBLISH_DIR is a path to binary root. Also, we'll need to support other servers:

Suggested change
COPY ${PUBLISH_DIR}/${TARGETOS}-${TARGETARCH}/dist/ /azuremcpserver/
WORKDIR /azuremcpserver
COPY ${PUBLISH_DIR} /mcpserver/
WORKDIR /mcpserver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, to support multiple servers, we need to start passing the CLI name in. This is a little difficult as ENTRYPOINT doesn't have access to build variables and doesn't evaluate environment variables, se we can't do something simple like:

ENTRYPOINT ["./${CLI_NAME}", "server", "start"]

or even

ENV CLI=${CLI_NAME}
ENTRYPOINT ["./$CLI", "server", "start"]

If we use the exec form, but invoke the shell, we can still wire up additional docker run args:

ENV CLI=${CLI_NAME}
ENTRYPOINT ["sh", "-c", "./$CLI server start $@"]

I'm not sure how this compares to the shell form:

ENV CLI=${CLI_NAME}
ENTRYPOINT "./$CLI" server start $0

Copy link
Member

@hallipr hallipr Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the shell-via-exec form, I was able to pass additional command line parameters through a docker run call:

> docker run azure-sdk/template-mcp:0.0.12-alpha.12345 --version
0.0.12-alpha.12345+3af3798511a7cf2441b662c2473941070331c5de

Comment on lines +77 to +79
foreach ($os in $operatingSystems) {

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed anymore?

Suggested change
foreach ($os in $operatingSystems) {
}

@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Oct 12, 2025
@joshfree joshfree added server-Azure.Mcp Azure.Mcp.Server tools-Docker Docker container / setup installer labels Oct 12, 2025
@joshfree joshfree added this to the 2025-10 milestone Oct 12, 2025
@g2vinay g2vinay added the Do Not Merge Do Not Merge / WIP PRs label Oct 13, 2025
@conniey conniey modified the milestones: 2025-10, 2025-11 Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Do Not Merge / WIP PRs server-Azure.Mcp Azure.Mcp.Server tools-Docker Docker container / setup installer

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants