Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: tidy #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLI: tidy #84

wants to merge 2 commits into from

Conversation

casperdcl
Copy link

@casperdcl casperdcl commented Dec 17, 2024

/CC @gagb

@casperdcl
Copy link
Author

@microsoft-github-policy-service agree

@afourney
Copy link
Member

Looks interesting. Can you say more about shtab?
What shell are you using that isn't already doing tab completion?

@casperdcl
Copy link
Author

casperdcl commented Dec 20, 2024

Ah @afourney your question(s) imply a fundamental misunderstanding. Clearly some docs are missing here. Unsure about how much detail you'd prefer to see in the GitHub flavoured markdown README, though.

For example/comparison, DVC details its end-user completion usage in separate per-OS/shell tabs at https://dvc.org/doc/install/completion

@casperdcl casperdcl force-pushed the completion branch 2 times, most recently from b68b29d to 1ba0a8e Compare December 20, 2024 09:51
@casperdcl casperdcl mentioned this pull request Dec 20, 2024
4 tasks
@gagb gagb added the open for reviewing Invites community to help review this PR. label Dec 20, 2024
@gagb
Copy link
Contributor

gagb commented Dec 20, 2024

With this PR:
image

main:
image

@casperdcl thank you for the PR. This is what I see. I am not sure if the --print-completion is helpful?
I am open to simplifying the help instructions but not sure if adding another dependency is a good idea -- the syntax is already simple and helps keep the package lightweight? cc @afourney @jackgerrits

@casperdcl
Copy link
Author

ok rebased & removed shtab now

- follow-up to microsoft#46
makes external integration with e.g. `shtab` easy
@casperdcl casperdcl changed the title CLI: tidy & add completion CLI: tidy Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open for reviewing Invites community to help review this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic CLI help text
3 participants