[Draft] optee: share TA binaries through a global UUID map - #1142
Open
Praveen K Paladugu (praveen-pk) wants to merge 4 commits into
Open
[Draft] optee: share TA binaries through a global UUID map#1142Praveen K Paladugu (praveen-pk) wants to merge 4 commits into
Praveen K Paladugu (praveen-pk) wants to merge 4 commits into
Conversation
Praveen K Paladugu (praveen-pk)
changed the title
Sangho Lee (sangho2)
left a comment
Sangho Lee (sangho2)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your effort! Yes, we should differentiate shim-global from runner-global. I left some comments/suggestions.
Comment on lines
-172
to
-173
| /// The TA UUID to binary map for TA loading. | ||
| ta_uuid_map: TaUuidMap, |
Contributor
There was a problem hiding this comment.
Dropping ta_uuid_map is here is a bit concerning because we can no longer use shim's self. Instead, we could store &'static TaUuidMap here. This is an outstanding PR's direction (#1127).
Praveen K Paladugu (praveen-pk)
force-pushed
the
global_ta_uuid
branch
from
August 11, 2026 19:49
f66f315 to
7881679
Compare
Move the TA UUID-to-binary map out of individual shim instances so TA binaries can be registered once and reused across instances. This global map is required to support Dyanamically Loading TAs and using them across sessions. Protect the map with a spin-based RwLock and expose shim methods for storing and retrieving TA binaries. Register the LVBS runner's embedded TA during BSP initialization and resolve new TA instances through the shared map. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Restore TA_BINARIES, to keep supporting mulitple embedded binaries Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
TaUuidMap is already sychronized with an interior RwLock. An Arc wrapping adds un-necessary reference counting overhead. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Praveen K Paladugu (praveen-pk)
force-pushed
the
global_ta_uuid
branch
from
August 11, 2026 19:55
7881679 to
321b69f
Compare
This drops the need for deep copy while getting a binary. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the TA UUID-to-binary map out of individual shim instances so TA binaries can be registered once and reused across instances. This global map is required to support Dyanamically Loading TAs and using them across sessions.
Protect the map with a spin-based RwLock and expose shim methods for storing and retrieving TA binaries.
Register the LVBS runner's embedded TA during BSP initialization and resolve new TA instances through the shared map.