CvmAttestation: changing to use new cvm library for cvm attestation#4289
CvmAttestation: changing to use new cvm library for cvm attestation#4289yangjie-msft wants to merge 2 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates CVM (Confidential VM) attestation tests to use a new library from Azure/cvm-attestation-tools, replacing the previous Azure/confidential-computing-cvm-guest-attestation library. The update adds support for Intel TDX CVM attestation alongside the existing AMD SEV-SNP support.
Changes:
- Replaces the old attestation library with cvm-attestation-tools from GitHub
- Adds Intel TDX CPU support in addition to AMD SEV-SNP for CVM attestation
- Simplifies installation by using install.sh script instead of manual cmake/make build process
- Updates attestation validation to use string-based output checking instead of JWT decoding
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| lisa/microsoft/testsuites/cvm/cvm_attestation_tool.py | Refactored AzureCVMAttestationTests to use new cvm-attestation-tools library, updated repository URL, simplified installation process, changed attestation validation from JWT to string matching, and updated file output handling |
| lisa/microsoft/testsuites/cvm/cvm_attestation.py | Extended CPU type check to support Intel TDX in addition to AMD SEV-SNP, added config file selection logic based on CPU type |
|
@yangjie-msft Do we expect guest attestation to fail when the VM is deployed with encryption type I think ideally we would still test platform attestation for NonPersistedTPM but skip guest attestation if it is not possible. In LISA, the |
For stateless CVM both guest and platform attestation will need to be run, so both tests should pass. |
Figure out it was related to SB setting. Now just waiting for final changes and meaningful commit messages. |
|
@LiliDeng LGTM |
using https://github.com/[Azure/cvm-attestation-tools](https://github.com/Azure/cvm-attestation-tools) for cvm attestation tests and adding support for tdx cvm attestation tests.