-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navvis files for unit tests #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these files needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has 0 bytes.
Unable to render rich display
Invalid image source.
Maybe it was intended.
How large is this test data? I would very much avoid committing it to the repo, which would force all users to download it even though it is used only for testing. Instead, 1) add it as a git submodule or 2) zip it, add it as release artefact, and download it when running the tests. I prefer option 2. |
yes we can do option 2 and add a comment if you want test |
I agree, I was also proposing the same here :) Now my question is, will we anyways download all this data when we do |
By default |
Add NavVis test files for testing.
test data restored from https://github.com/microsoft/scantools/tree/main/test_data