Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: warn unsupported auth flows #5768

Merged
merged 23 commits into from
Nov 19, 2024
Merged

Task: warn unsupported auth flows #5768

merged 23 commits into from
Nov 19, 2024

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Nov 13, 2024 •
edited
Loading

Overview

Closes #5403

Notes

  • Add tests to confirm supporting endpoints
  • Add logs to stream warnings
  • Stream-line messages to match A/C
  • Surface the messages in the extension
  • Surface the messages in the CLI

@thewahome thewahome requested a review from a team as a code owner November 13, 2024 10:31
@thewahome thewahome marked this pull request as draft November 13, 2024 10:31
thewahome and others added 18 commits November 13, 2024 15:31
@thewahome
remove unnecessary validation functions
3269e17
@thewahome
Add tests to support previously failing schemes
0d7ee41
@thewahome
Merge branch 'main' into task/warn-unsupported-auth-flows
aebfdc5
enable logging to warn users
0d98e86
Set warning message
afe8aeb
@thewahome
Merge branch 'main' into task/warn-unsupported-auth-flows
1904a89
@thewahome
Merge branch 'main' into task/warn-unsupported-auth-flows
eb4e57e
@thewahome
Merge branch 'main' into task/warn-unsupported-auth-flows
4ba1b4d
@thewahome
change message to allow filtering
5cda494
@thewahome
Tag warning with categpry
e2e97c1
@thewahome
log authentication error warnings in output channel
0f1485d
@thewahome
Merge branch 'main' into task/warn-unsupported-auth-flows
6c6b661
@thewahome
fix message
df40f4e
@thewahome
pass kiotaOutputChannel as dependency
0a4270a
@thewahome
log warnings and open output tab
cf674db
@thewahome
show warning message and point to logs
4cf39a5
@thewahome
add output channel in tests
ca04555
@thewahome
Merge branch 'main' into task/warn-unsupported-auth-flows
36ae532
@thewahome thewahome marked this pull request as ready for review November 19, 2024 12:15
@thewahome thewahome merged commit 065a960 into main Nov 19, 2024
212 checks passed
@thewahome thewahome deleted the task/warn-unsupported-auth-flows branch November 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@calebkiage calebkiage calebkiage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Plugin generation] Kiota should warn users when api contains unsupported auth flows
3 participants
@thewahome @calebkiage @baywet