Task: throw error on implicit flow #5692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebkiage
reviewed
Oct 30, 2024
tests/Kiota.Builder.Tests/Plugins/PluginsGenerationServiceTests.cs
Outdated
Show resolved
Hide resolved
…m/microsoft/kiota into task/throw-error-on-implicit-flow
|
I think you should add the failing tests for other auth flows as well |
|
|
As mentioned in the planning session today and in the issue #5403 (comment) there was a change in the desired experience and we now should not fail for any auth validation and just warn users that they auth might not be supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
No longer closes the expected issue and will be closed