Initial fixes to restore Java IT #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
commented
Oct 18, 2024
baywet
reviewed
Oct 18, 2024
There was a problem hiding this comment.
I went ahead and merged my earlier PR #5624 to avoid having competing work. Updated this one from main.
It seems that all those changes do not solve the parsable issue.
https://github.com/microsoft/kiota/actions/runs/11401393719/job/31726688511?pr=5632
|
ok so after looking more into it, all the parsable errors can be ignored. They are a side effect of the circular reference for the integration model. |
|
(I'll keep sharing my findings on the original issue) |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
@andrueastman to give it another review since a lot of the changes here are effectively mine
|
Thanks for taking over this one @baywet 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only fixing the most evident issues with the Java IT tests.
fixes #5610