fixes incompatibility with new odata primitive format. #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
approved these changes
Oct 8, 2024
|
|
Generation run for this PR at https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=166335&view=logs&j=0c914960-8b50-5299-c9aa-dd3c9595168e&t=10763a1c-e2a2-5bd5-46f6-1e38af74bcce With the generated commit confirming no composed types at microsoftgraph/msgraph-sdk-dotnet@main...kiota/v1.0/pipelinebuild/166335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to microsoft/OpenAPI.NET.OData#589
Latest changes in the conversion library add the
typeproperty to the schema of theReferenceNumerictype used in odata primitives.This causes incompatibility with the
IsODataPrimitiveTypewhich only expects one schema to have the type ofstring.This PR updates the implementation so that the new scenario is captured and older documents with the older format are not broken by this change.