Fix Cyclic Dependencies in Go

[rkodev]

Resolves #2834

Fixes cyclic dependencies by flattening models affected by cyclic depndecies i.e when a cyclic depedency is detected the affected packages will be flattened and migrated to the rot models package.

For example
models -> submodule1 -> submodule2 -> submodule3 -> submodule2
will be flattened by migrating everything under submodule2 to the root models package

Testing:

1. Enabled suppressed integrated tests
2. Added unit tests

[andrueastman]

Just checking first,
Aren't the changes proposed for #2834 breaking and proposed for the next major version of Kiota? Or does the approach here avoid breaking existing generations?

[rkodev]

@andrueastman so this will not break the existing code releases as it only flattens the models when it detects a circular reference. The issue was suggesting flattening the entire package but in this case the solution only flattens packages that have a circular reference https://github.com/microsoft/kiota/blob/fix/go-cyclic-dependencies/src/Kiota.Builder/Refiners/GoRefiner.cs#L289

[baywet]

Great initial work!

[baywet]

Thank you for making the changes!

[andrueastman]

Just a couple of comments. Otherwise, this looks good to me.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[andrueastman]

👍🏼