Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: item path escaping regression #5434

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: item path escaping regression #5434

merged 2 commits into from
Sep 18, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Sep 18, 2024 •
edited
Loading

Fixes #5433

andrueastman
andrueastman commented Sep 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrueastman
Copy link
Member Author

Validation with V1 metadata at https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=163746&view=logs&j=0c914960-8b50-5299-c9aa-dd3c9595168e&t=10763a1c-e2a2-5bd5-46f6-1e38af74bcce

(Will rerun pipeline for all langauges once PR is merged)

@andrueastman andrueastman changed the title fix: excessive path escaping fix: item path escaping regression Sep 18, 2024
@andrueastman andrueastman marked this pull request as ready for review September 18, 2024 08:52
@andrueastman andrueastman requested a review from a team as a code owner September 18, 2024 08:52
@baywet baywet merged commit b5eeeb5 into main Sep 18, 2024
209 checks passed
@baywet baywet deleted the andrueastman/fixRegrtession branch September 18, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escaping Item keywords in request builders also escapes unrelated request builder properties.
2 participants
@andrueastman @baywet