Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/function descriptions #5372

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Bugfix/function descriptions #5372

merged 3 commits into from
Sep 10, 2024

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Sep 10, 2024 •
edited
Loading

Fixes #5301

functions[n].description should default to paths[n].description and when description is not available, default to paths[n].summary

conversationStarter[n].text should default to paths[n].summary and when summary is not available, default to paths[n].description

@samwelkanda samwelkanda marked this pull request as ready for review September 10, 2024 05:28
@samwelkanda samwelkanda requested a review from a team as a code owner September 10, 2024 05:28
andrueastman
andrueastman reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add a changelog entry as well? Otherwise, looks good to me.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrueastman andrueastman mentioned this pull request Sep 10, 2024
Merged
@samwelkanda samwelkanda merged commit 6bfabf0 into main Sep 10, 2024
209 checks passed
@samwelkanda samwelkanda deleted the bugfix/function-descriptions branch September 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
2 participants
@samwelkanda @andrueastman