fix/stack overflow #5370
Merged
fix/stack overflow #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
calebkiage
reviewed
Sep 10, 2024
|
calebkiage
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5369
regression introduced in #5279
Before resulting to reverting the Equals implementation I explored making the visited schema hashset a property/constructor parameter, which results in non-resuability of the comparer or having to create new instances for each comparison (lots of new allocs).
I've also explored re-implementing SequenceEquals, this results in lots of additional duplicated code from the standard library.
Lastly, I've replaced added ordering before a bunch of sequence equal since the order should NOT matter