Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge schemas in allOf when generating a sliced OpenAPI document. #5308

Merged
merged 17 commits into from
Sep 9, 2024
Merged

merge schemas in allOf when generating a sliced OpenAPI document. #5308

merged 17 commits into from
Sep 9, 2024

Conversation

calebkiage
Copy link
Contributor

No description provided.

@petrhollayms petrhollayms linked an issue Sep 5, 2024 that may be closed by this pull request
Kiota should resolve polymorphic references (oneOf, allOf, anyOf) for request bodies when generating sliced OpenAPI for plugin #5164
Closed
@calebkiage calebkiage marked this pull request as ready for review September 5, 2024 10:05
@calebkiage calebkiage requested a review from a team as a code owner September 5, 2024 10:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

baywet
baywet approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@calebkiage calebkiage merged commit 5fdd261 into main Sep 9, 2024
205 of 207 checks passed
@calebkiage calebkiage deleted the feat/allof-validation branch September 9, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@SilasKenneth SilasKenneth Awaiting requested review from SilasKenneth

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
3 participants
@calebkiage @baywet @SilasKenneth