Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update kiota vs code extension #4500

Merged
merged 211 commits into from
Aug 22, 2024
Merged

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Apr 16, 2024

Fixes #4293
Fixes #4719

User Story 1

  • Add new API Explorer container + my workspace container
  • Add/Modify/Update existing 'add', 'filter', 'generate', 'open file' icons
  • Modify 'add API' function to support searching or pasting a url to open a API description on open API explorer and update dialog
  • Add/Modify/Update existing icons on tree items
  • Add delete confirmation dialog
  • Add dialog to enable generating a client, plugin, or API manifest
  • Modify steps to generate each

@ElinorW ElinorW changed the base branch from main to feature/plugin April 23, 2024 14:21
@baywet baywet changed the base branch from feature/plugin to main April 26, 2024 15:07
vscode/microsoft-kiota/src/steps.ts Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
@ElinorW ElinorW requested a review from baywet August 19, 2024 14:19
vscode/microsoft-kiota/src/extension.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/src/steps.ts Outdated Show resolved Hide resolved
vscode/microsoft-kiota/package.nls.ar.json Outdated Show resolved Hide resolved
Copy link
Contributor

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that this work has initiated work to break functions down into manageable code files

thewahome
thewahome previously approved these changes Aug 20, 2024
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.
Thanks for pushing this through @ElinorW

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the long haul on this one.
When you merge, please squash (arrow next to the merge button) as there's a lot of history here.

@ElinorW ElinorW merged commit 9b94384 into main Aug 22, 2024
208 of 209 checks passed
@ElinorW ElinorW deleted the elinor/add-kiota-workspace branch August 22, 2024 09:34
@sebastienlevert
Copy link
Contributor

WE MADE IT! 🎉🎉🎉🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
7 participants