-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress errors in .ts files using ts-ignore #4398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution.
Can you please:
- add a changelog entry
- update the corresponding unit test
Thanks!
@microsoft-github-policy-service agree company="Cybozu" |
|
Pull Request is not mergeable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
Fixes #4397
Added
// @ts-ignore
comment line as per discussion to suppress typecheck errors.Currently, generated TypeScript
.ts
files contain imports that are never referenced in the code.This causes TypeScript typecheck to fail in projects where
tsconfig.json
compiler optionnoUnusedLocals: true
is set.Example: Vitejs template tsconfig.json