Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bitwise enum serialization in typescript. #3261

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Sep 6, 2023

Fixes #3260

Typescript writers are creating multidimensional collections for flagged enums that are collections. This fixes the issues by handling them as collections of enums.

Sample generation of PR at microsoftgraph/msgraph-sdk-typescript#361

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman marked this pull request as ready for review September 6, 2023 12:28
@andrueastman andrueastman requested a review from a team as a code owner September 6, 2023 12:28
@andrueastman andrueastman merged commit b32cd8b into main Sep 6, 2023
171 checks passed
@andrueastman andrueastman deleted the andrueastman/fixTypescriptEnums branch September 6, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript enums and flag are misaligned for serialization method
2 participants