Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes enum type disambiguation with default in constructors in dotnet #3239

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

andrueastman
Copy link
Member

Closes #3233

Also fixes generation of WithUrl in ApiClient class in the event it has operations as it won't have the rawUrl constructor and can be changed with baseUrl

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman marked this pull request as ready for review August 31, 2023 14:43
@andrueastman andrueastman requested a review from a team as a code owner August 31, 2023 14:43
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@andrueastman andrueastman merged commit ceee13d into main Aug 31, 2023
169 of 170 checks passed
@andrueastman andrueastman deleted the andrueastman/fixEnumdefaults branch August 31, 2023 14:46
@HowardvanRooijen
Copy link

Awesome work! Thanks very much!

@baywet
Copy link
Member

baywet commented Aug 31, 2023

@HowardvanRooijen we should have another preview going out this afternoon (EST)

@HowardvanRooijen
Copy link

Fantastic. Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# CS1061 error generated because of Type naming collision.
3 participants