Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uuid for indexer params #3181

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix uuid for indexer params #3181

merged 2 commits into from
Aug 22, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Aug 22, 2023 •
edited
Loading

Resolves #3176

  1. Converts UUID indexers to string when adding it to parameters dictionary. Resolves go compilation error.
  2. Avoid unnecessary importation of strconv in import statements when using uuid params for indexer methods

@rkodev rkodev requested a review from a team as a code owner August 22, 2023 06:24
andrueastman
andrueastman reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just need to fix the failing CI check

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rkodev rkodev enabled auto-merge (squash) August 22, 2023 06:49
@rkodev rkodev merged commit 8cc0a84 into main Aug 22, 2023
94 checks passed
@rkodev rkodev deleted the fix/go-uuid-param branch August 22, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path Parameters UUIDs are not converted to string before assignment in Go
2 participants
@rkodev @andrueastman