Generated Class and CompletableFuture<Void> Annotations

[ramsessanchez]

Fixes: #3106

Also,
Noticed an edge case that wasn't considered when I removed the annotations from 'Void' returns.
Initially removed annotations when the return value is 'Void', however Api-Linting for the Java-SDK is telling us that an annotation is still needed if the Void return is wrapped in a completable future.

    public java.util.concurrent.CompletableFuture<Void> delete() {
        return delete(null);
    }

Needs to be

    @jakarta.annotation.Nonnull
    public java.util.concurrent.CompletableFuture<Void> delete() {
        return delete(null);
    }

[baywet]

please add a changelog entry.
You're probably missing adding a using in the refiner for the generated annotation.

[ramsessanchez]

@baywet , Should I add a using in the refiner or simply use the full annotation in a similar way to the other annotations? It would be like: "jakarta.annotation.Generated("com.microsoft.kiota") instead of just "Generated"
Also, I put "com.microsoft.kiota" as the place holder for the 'name' value that is required for the generation annotation, is this a good name to use or is there a better option in your opinion?

[baywet]

I think the name is good, you should probably centralize the constant in the JavaConventionService though.
As per the refiner, just add Generated, additional symbol will be in the import statement and that's not going to work well.

[ramsessanchez]

additional symbol will be in the import statement and that's not going to work well.
What do you mean here?

Also, would that then be a standard that we should refactor? If we are already using the jakarta annotations across the board quite frequently then should it simply be added to the refiner? So that the Nullable (and NonNull) annotations are also just 'Nullable' rather than the current 'jakarta.annotation.Nullable'?

[baywet]

I misread your prior question. Please go ahead and use the full name for the annotation to align with others. Sorry about the confusion.
We can go to the refiner way, which would map closer to the other languages, however if we do that we need to add those keywords to the reserved name provider (Nonnull, Nullable, Generated). Your call.

[baywet]

Yep, it was because I hadn't added the fully qualified name. Just added that, should be good soon.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.0% Coverage
0.0% Duplication