Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Jakarta Annotations #3094

Merged
merged 10 commits into from
Aug 11, 2023
Merged

Java Jakarta Annotations #3094

merged 10 commits into from
Aug 11, 2023

Conversation

ramsessanchez
Copy link
Contributor

Adjusting the Java code writers use Jakarta annotations rather than the prior Javax annotations.

@ramsessanchez ramsessanchez requested a review from a team as a code owner August 8, 2023 22:42
@ramsessanchez
Copy link
Contributor Author

The tests will fail as we are waiting for Kiota-Java Components to be bumped once this pr is approved: microsoft/kiota-java#553

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.
Any chance you could add a changelog entry for the same before the merge?

@andrueastman
Copy link
Member

baywet
baywet previously approved these changes Aug 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ramsessanchez ramsessanchez merged commit af7bdcf into main Aug 11, 2023
85 of 94 checks passed
@ramsessanchez ramsessanchez deleted the jakarta_annotations_for_java branch August 11, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give the possibility to generate @jakarta.annotation instead of @javax.annotation
3 participants