Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerated header support for C# language #3034

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Autogenerated header support for C# language #3034

merged 3 commits into from
Aug 1, 2023

Conversation

samarthasthana
Copy link
Contributor

@samarthasthana samarthasthana commented Aug 1, 2023 •
edited by baywet
Loading

fixes #2886

Added support to write an autogenerated header for class and enum types for C# language generation.
This header is the minimum header that is supported by Stylecop
Ref link: https://shishkin.wordpress.com/2008/07/08/stylecop-how-to-ignore-generated-code/

@samarthasthana samarthasthana requested a review from a team as a code owner August 1, 2023 19:02
@samarthasthana samarthasthana mentioned this pull request Aug 1, 2023
Closed
baywet
baywet requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. One comment + can you add an entry to the Changelog please (unreleased, changed) ?

src/Kiota.Builder/Writers/CSharp/CodeClassDeclarationWriter.cs Show resolved Hide resolved
baywet
baywet approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet enabled auto-merge August 1, 2023 19:37
@baywet baywet merged commit 594ae64 into microsoft:main Aug 1, 2023
90 of 91 checks passed
@samarthasthana samarthasthana deleted the sasthana/add-autogeneration-header branch August 1, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add auto-generated comment in CSharp to avoid triggering static analysis
2 participants
@samarthasthana @baywet