Skip to content

Commit

Permalink
Merge branch 'main' into fix/go-cyclic-dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
rkodev authored Oct 3, 2024
2 parents 6d02976 + f837b76 commit 30a234d
Show file tree
Hide file tree
Showing 42 changed files with 691 additions and 395 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Build image
uses: docker/build-push-action@v6.7.0
uses: docker/build-push-action@v6.9.0
with:
push: false
platforms: linux/amd64,linux/arm64/v8,linux/arm/v7
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
run: echo "date=$(date +'%Y%m%d')" >> $GITHUB_OUTPUT
- name: Push to GitHub Packages - Nightly
if: contains(github.ref, env.PREVIEW_BRANCH)
uses: docker/build-push-action@v6.7.0
uses: docker/build-push-action@v6.9.0
with:
push: true
platforms: linux/amd64,linux/arm64/v8,linux/arm/v7
Expand All @@ -104,7 +104,7 @@ jobs:
# we can't get the sequence number from ADO so we default it back to github run number
- name: Push to GitHub Packages - Release
if: contains(github.ref, 'refs/tags/v')
uses: docker/build-push-action@v6.7.0
uses: docker/build-push-action@v6.9.0
with:
push: true
platforms: linux/amd64,linux/arm64/v8,linux/arm/v7
Expand Down
12 changes: 1 addition & 11 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,7 @@
"/property:GenerateFullPaths=true",
"/consoleloggerparameters:NoSummary"
],
"problemMatcher": "$msCompile",
"dependsOn": ["checkout:sample:locks"]
},
{
"label": "checkout:sample:locks",
"type": "process",
"command": "git",
"args": ["checkout", "**/kiota-lock.json"],
"options": {
"cwd": "${workspaceFolder}/samples"
}
"problemMatcher": "$msCompile"
},
{
"label": "test",
Expand Down
12 changes: 9 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Added

- Control generated type access modifier for C# via `--type-access-modifier` flag. [#4788](https://github.com/microsoft/kiota/issues/4788)

### Changed
Expand All @@ -19,13 +20,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed a bug where a path segment named "item" after a single parameter path segment would derail generation. [#4814](https://github.com/microsoft/kiota/issues/4814)
- Fixed a bug where collection/array of primitive types members for union/intersection types would be ignored. [#5283](https://github.com/microsoft/kiota/issues/5283)
- Updated dependencies command and view to reflect the availability of bundles. [#5317](https://github.com/microsoft/kiota/issues/5317)
- Fixed a when generating a plugin when only an operation is selected in the root node in the extension. [#5300](https://github.com/microsoft/kiota/issues/5300)
- Fixed a bug when generating a plugin when only an operation is selected in the root node in the extension. [#5300](https://github.com/microsoft/kiota/issues/5300)
- Fixed a bug where function descriptions in plugin manifest defaults to path summary instead of description. [#5301](https://github.com/microsoft/kiota/issues/5301)
- Fixed a bug where TypeScript would not properly build URIs with uppercase first characters query parameter names.[#5382](https://github.com/microsoft/kiota/issues/5382)
- Fixed a bug where the description special characters are encoded. [5286](https://github.com/microsoft/kiota/issues/5286)
- Fixed a bug where the description special characters are encoded. [#5286](https://github.com/microsoft/kiota/issues/5286)
- Fixed a bug where python constructor parameters are being cast to strings leading to bugs as the types is unknown on graph call. [microsoftgraph/msgraph-sdk-python#165](https://github.com/microsoftgraph/msgraph-sdk-python/issues/165)
- Fixed a bug where child path segment from single parameter path segment would be incorrectly escaped. [#5433](https://github.com/microsoft/kiota/issues/5433)
- Fixed inconsistent typing information generated for `ParsableFactory` and stream return types in python [kiota-abstractions-python#533](https://github.com/microsoft/kiota-abstractions-python/issues/333)
- Fixed inconsistent typing information generated for `ParsableFactory` and stream return types in python [kiota-abstractions-python#533](https://github.com/microsoft/kiota-abstractions-python/issues/333)
- Fixed a bug where untyped not imports in TypeScripts would not be erasable. [microsoft/kiota-typescript#1381](https://github.com/microsoft/kiota-typescript/issues/1381)
- Updated schema link in plugin manifest to the correct url. [#5441](https://github.com/microsoft/kiota/issues/5441)
- Removed registration of default serialization and deserialization classes in client constructor. [#5478](https://github.com/microsoft/kiota/pull/5478)
- Fixed incorrect type name generation in aliased scenario in TS due to broad searching of types in root namespaces. [#5404](https://github.com/microsoft/kiota/issues/5404)
- Fixed incorrect type mapping in request builders with subsequent paths with the same name. [#5462](https://github.com/microsoft/kiota/issues/5462)
- Fixed cyclic depencies in generated Go code. [#2834](https://github.com/microsoft/kiota/issues/2834)

## [1.18.0] - 2024-09-05
Expand Down
16 changes: 8 additions & 8 deletions it/csharp/dotnet.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.12.0" />
<PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Authentication.Azure" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.12.4" />
<PackageReference Include="Microsoft.kiota.Serialization.Multipart" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.12.4" />
<PackageReference Include="Azure.Identity" Version="1.12.1" />
<PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Authentication.Azure" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.13.0" />
<PackageReference Include="Microsoft.kiota.Serialization.Multipart" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.13.0" />

<Compile Remove="basic\**" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion it/java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<kiota-java.version>1.4.0</kiota-java.version>
<kiota-java.version>1.5.0</kiota-java.version>
</properties>

<dependencies>
Expand Down
6 changes: 3 additions & 3 deletions it/python/requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ yapf==0.40.2

zipp==3.20.2 ; python_version >= '3.7'

aiohttp==3.10.6 ; python_version >= '3.6'
aiohttp==3.10.8 ; python_version >= '3.6'

aiosignal==1.3.1 ; python_version >= '3.7'

Expand All @@ -92,7 +92,7 @@ h2==4.1.0

hpack==4.0.0 ; python_full_version >= '3.6.1'

httpcore==1.0.5 ; python_version >= '3.7'
httpcore==1.0.6 ; python_version >= '3.7'

httpx[http2]==0.27.2

Expand Down Expand Up @@ -136,5 +136,5 @@ sniffio==1.3.1 ; python_version >= '3.7'

uritemplate==4.1.1 ; python_version >= '3.6'

yarl==1.12.1 ; python_version >= '3.7'
yarl==1.13.1 ; python_version >= '3.7'

96 changes: 48 additions & 48 deletions it/typescript/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions it/typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
"devDependencies": {
"@es-exec/esbuild-plugin-start": "^0.0.5",
"@stylistic/eslint-plugin-ts": "^2.8.0",
"@types/node": "^22.7.0",
"@typescript-eslint/eslint-plugin": "^8.7.0",
"@typescript-eslint/parser": "^8.7.0",
"@types/node": "^22.7.4",
"@typescript-eslint/eslint-plugin": "^8.8.0",
"@typescript-eslint/parser": "^8.8.0",
"esbuild": "^0.24.0",
"eslint": "^9.11.1",
"eslint-config-prettier": "^9.1.0",
Expand Down
18 changes: 9 additions & 9 deletions src/Kiota.Builder/Kiota.Builder.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,22 @@
<PackageReference Include="AsyncKeyedLock" Version="7.0.1" />
<PackageReference Include="DotNet.Glob" Version="3.1.3" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.1" />
<PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.12.4" />
<PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.12.4" />
<PackageReference Include="Microsoft.kiota.Serialization.Multipart" Version="1.12.4" />
<PackageReference Include="Microsoft.OpenApi" Version="1.6.21" />
<PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.13.0" />
<PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.13.0" />
<PackageReference Include="Microsoft.kiota.Serialization.Multipart" Version="1.13.0" />
<PackageReference Include="Microsoft.OpenApi" Version="1.6.22" />
<PackageReference Include="Microsoft.OpenApi.ApiManifest" Version="0.5.5-preview" />
<PackageReference Include="Microsoft.OpenApi.Readers" Version="1.6.21" />
<PackageReference Include="Microsoft.OpenApi.Readers" Version="1.6.22" />
<PackageReference Include="Microsoft.Plugins.Manifest" Version="1.0.0-preview" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.11.20">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="YamlDotNet" Version="16.1.2" />
<PackageReference Include="YamlDotNet" Version="16.1.3" />
<ProjectReference Include="..\Kiota.Generated\KiotaGenerated.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
</ItemGroup>
<ItemGroup>
Expand Down
5 changes: 4 additions & 1 deletion src/Kiota.Builder/KiotaBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,10 @@ x.Parent is CodeIndexer ||
Parallel.ForEach(unmappedRequestBuilderTypes, parallelOptions, x =>
{
var parentNS = x.Parent?.Parent?.Parent as CodeNamespace;
x.TypeDefinition = parentNS?.FindChildrenByName<CodeClass>(x.Name).MinBy(shortestNamespaceOrder);
CodeClass[] exceptions = x.Parent?.Parent is CodeClass parentClass ? [parentClass] : [];
x.TypeDefinition = parentNS?.FindChildrenByName<CodeClass>(x.Name)
.Except(exceptions)// the property method should not reference itself as a return type.
.MinBy(shortestNamespaceOrder);
// searching down first because most request builder properties on a request builder are just sub paths on the API
if (x.TypeDefinition == null)
{
Expand Down
Loading

0 comments on commit 30a234d

Please sign in to comment.