Use OpenAPI.NET validation API

microsoft · Oct 17, 2024 · 1812e9b · 1812e9b
1 parent 2bdd1bb
commit 1812e9b
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/src/Kiota.Builder/Plugins/PluginsGenerationService.cs b/src/Kiota.Builder/Plugins/PluginsGenerationService.cs
@@ -10,10 +10,12 @@
 using Kiota.Builder.Extensions;
 using Kiota.Builder.OpenApiExtensions;
 using Microsoft.OpenApi.ApiManifest;
+using Microsoft.OpenApi.Extensions;
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Services;
 using Microsoft.OpenApi.Writers;
 using Microsoft.Plugins.Manifest;
+using ValidationRuleSet = Microsoft.OpenApi.Validations.ValidationRuleSet;
 
 namespace Kiota.Builder.Plugins;
 
@@ -258,6 +260,21 @@ private OpenApiDocument GetDocumentWithTrimmedComponentsAndResponses(OpenApiDocu
 
     private PluginManifestDocument GetManifestDocument(string openApiDocumentPath)
     {
+        // Validate OpenAPI
+        var ruleSet = new ValidationRuleSet
+        {
+            Microsoft.Plugins.Manifest.OpenApiRules.OpenApiServerUrlRule.ServerUrlMustBeHttps,
+            Microsoft.Plugins.Manifest.OpenApiRules.OpenApiCombinedAuthFlowRule
+                .PathsCanOnlyHaveOneSecuritySchemePerOperation(OAIDocument.SecurityRequirements),
+            Microsoft.Plugins.Manifest.OpenApiRules.OpenApiRequestBodySchemaRule.RequestBodySchemaObjectsMustNeverBeNested,
+            Microsoft.Plugins.Manifest.OpenApiRules.OpenApiApiKeyBearerRule.ApiKeyNotSupportedOnlyBearerPlusHttp(OAIDocument.SecurityRequirements)
+        };
+        var errors = OAIDocument.Validate(ruleSet)?.ToArray();
+        if (errors != null && errors.Length != 0)
+        {
+            var message = string.Join(Environment.NewLine, errors.Select(e => $"{e.Pointer}: {e.Message}"));
+            throw new InvalidOperationException(message);
+        }
         var (runtimes, functions, conversationStarters) = GetRuntimesFunctionsAndConversationStartersFromTree(OAIDocument, Configuration.PluginAuthInformation, TreeNode, openApiDocumentPath);
         var descriptionForHuman = OAIDocument.Info?.Description is string d && !string.IsNullOrEmpty(d) ? d : $"Description for {OAIDocument.Info?.Title}";
         var manifestInfo = ExtractInfoFromDocument(OAIDocument.Info);
@@ -297,8 +314,6 @@ private PluginManifestDocument GetManifestDocument(string openApiDocumentPath)
                                             .ToList()
             };
 
-        var ruleSet = PluginManifestRuleSets.GetDefaultAuthoringRuleSet();
-        pluginManifestDocument.Validate(ruleSet, new ValidationContext(schemaVersion));
         return pluginManifestDocument;
     }