adds validation with generated project #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
baywet
approved these changes
Sep 23, 2024
andrueastman
merged commit a6f130d
into
andrueastman/resolvetypingerrors
41 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Related to microsoft/kiota#5453
Resolves typing errors in library and generated code by updating the
ParsableFactorytype to be a type variable across the SDK.Adds a generated project that validates that running the static type checker does not yield errors due to inconsistencies in the typing information used in the generated code and the libraries.
Sample run at https://github.com/microsoft/kiota-abstractions-python/actions/runs/10994899545