igvm: Update SevVmsa structure definition. Pad to full 4K.#109
igvm: Update SevVmsa structure definition. Pad to full 4K.#109RARelph wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree company="AMD" |
|
Jon and I discussed this offline that I think it might make more sense to move away from defining some of these architectural definitions in the I think this would apply to quite a few things in this crate so I need to sit down and find some time to refactor this, but would mean every time hardware changes/adds a new feature, we're not required to add all these definitions because IGVM shouldn't be the authoritative definition for specific hardware. This does mean consumers of this crate will need to carry their own definition of hardware specific fields, but I think that's fine. I wonder if we should have a Thoughts? |
|
I think moving architecture specifics to an architecture-specific crate makes sense. Sounds like more work... but it makes sense. |
|
Mainly, I don't want this crate to become a defacto source for hardware specific definitions. Even if we might use a few bit definitions, they should be stable but we shouldn't have to need to update IGVM's definition for a new hardware feature. |
Fixes #108 - Updates SevVmsa with documented VMSA fields and extends structure to 4K page size.