igvm_c: fix pkg-config file and header installation#104
Merged
chris-oo merged 1 commit intomicrosoft:mainfrom Feb 23, 2026
Merged
igvm_c: fix pkg-config file and header installation#104chris-oo merged 1 commit intomicrosoft:mainfrom
chris-oo merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
A good next step will be to have cargo-c generating the headers if possible, but out of scope of this fix I guess. |
The generated igvm.pc had an empty Cflags field because cargo-c header support was fully disabled (enabled = false). Headers were also installed manually by the Makefile rather than through cargo-c. Switch to generation = false so that cargo-c knows headers exist but does not run cbindgen (which is handled by the Makefile). Use install.include to point cargo-c directly at the cbindgen-generated headers in igvm_c/include/, and let cargo cinstall take care of header installation. Add a dependency from $(LIBIGVM) on the generated headers so that cargo cbuild always runs after cbindgen. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
stefano-garzarella
force-pushed
the
fix-pkgconfig
branch
from
7d0f371 to
ac8d96b
Compare
luigix25
pushed a commit
to luigix25/igvm
that referenced
this pull request
Mar 5, 2026
The generated igvm.pc had an empty Cflags field because cargo-c header support was fully disabled (enabled = false). Headers were also installed manually by the Makefile rather than through cargo-c. Switch to generation = false so that cargo-c knows headers exist but does not run cbindgen (which is handled by the Makefile). Use install.include to point cargo-c directly at the cbindgen-generated headers in igvm_c/include/, and let cargo cinstall take care of header installation. Add a dependency from $(LIBIGVM) on the generated headers so that cargo cbuild always runs after cbindgen. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated igvm.pc had an empty Cflags field because cargo-c header support was fully disabled (enabled = false). Headers were also installed manually by the Makefile rather than through cargo-c.
Switch to generation = false so that cargo-c knows headers exist but does not run cbindgen (which is handled by the Makefile). Use install.include to point cargo-c directly at the cbindgen-generated headers in igvm_c/include/, and let cargo cinstall take care of header installation.
Add a dependency from $(LIBIGVM) on the generated headers so that cargo cbuild always runs after cbindgen.