This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
Adding a Spec documentation #496
Open
paryoja
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
paryoja:document/spec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezruby
reviewed
Oct 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort on this! I added some comments and it would be good to update a link to the md rendered page in PR description for reviewers:
https://github.com/paryoja/hyperspace/blob/document/spec/SPEC.md
dc8e534
to
40e1b24
Compare
sezruby
reviewed
Nov 3, 2021
d3e7846
to
0c1c022
Compare
sezruby
reviewed
Nov 4, 2021
046f5cc
to
46e10e4
Compare
applying reviews and format blank lines consistently fix notation used for keywords
46e10e4
to
8f91215
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
Draft of the spec documentation.
What changes were proposed in this pull request?
Documentation is added.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test not required.