-
Notifications
You must be signed in to change notification settings - Fork 52
Array accesses and bounds #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
llvm-beanz
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
llvm-beanz:cbieneman/array-access-ub
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds language documenting that out of bounds accesses for arrays is undefined behavior, and that zero-sized arrays are disallowed. This also restricts arrays of unknown size to strictly global resource declarations but allows omitting the array bound if it can be inferred from an initiailzer. Resolves microsoft#141
hekota
reviewed
Sep 11, 2025
llvm-beanz
added a commit
to llvm-beanz/hlsl-specs
that referenced
this pull request
Sep 16, 2025
After the meeting today we seem to have alignment here. I'm going to mark this proposal as under review with PR microsoft#634 as the main review for the spec contribution.
llvm-beanz
added a commit
that referenced
this pull request
Sep 17, 2025
After the meeting today we seem to have alignment here. I'm going to mark this proposal as under review with PR #634 as the main review for the spec contribution.
hekota
approved these changes
Sep 30, 2025
Member
hekota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
spall
reviewed
Oct 3, 2025
spall
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds language documenting that out of bounds accesses for arrays is undefined behavior, and that zero-sized arrays are disallowed.
This also restricts arrays of unknown size to strictly global resource declarations but allows omitting the array bound if it can be inferred from an initiailzer.
Resolves #141