Fix missing function parameter in search.py#1913
Closed
amoor22 wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix missing function parameter in search.py#1913amoor22 wants to merge 1 commit intomicrosoft:mainfrom
amoor22 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
In the `_reduce_response` function, a format call is made on the `self.reduce_system_prompt` string which contains a placeholder for `max_length` which is not provided in the format call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
_reduce_responsefunction in thesearch.pyfile in global_search.A format call is made on the
self.reduce_system_promptstring which contains a placeholder formax_lengthwhich is not provided in the format call.Proposed Changes
Add the missing parameter to the function call.
Checklist