Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choco Package for v0.15.1 #270

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

stuartpa
Copy link
Collaborator

@stuartpa stuartpa commented Mar 1, 2023

No description provided.

@@ -3,11 +3,10 @@
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
<metadata>
<id>sqlcmd</id>
<version>0.8.1</version>
<version>0.15.0</version>
Copy link
Collaborator

@shueybubbles shueybubbles Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.15.0<

can we change the pipeline that packs the package get the version from the current tag instead of hard coding it here? Then line 6 and line 20 can reference a variable like $version$ and the pipeline will pass version as a parameter to the pack.

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stuartpa stuartpa changed the title Choco Package for v0.15.0 Choco Package for v0.15.1 Mar 2, 2023
@shueybubbles
Copy link
Collaborator

looks like you need to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants