RespServerSession RESP3 update #1223
Open
+686
−585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
prvyk
force-pushed
the
resp3serversession
branch
3 times, most recently
from
2159e54 to
2b77659
Compare
|
This is a lot of refactoring and depending on .NET's force inlining capability. We need to make sure there are no performance regressions due to e.g. saturating the inline limits that .NET places internally. Also, see the BDN results here and identify any regressions: ee395dc#comments There seems to be general degradations all over the place. |
|
Would it be possible to break this PR up into two parts: (1) the force-inlined-method version of |
|
Yes, I was already working on that, will update the PR a bit later. |
In some sorted set commands, Garnet should emit double in RESP3.
Emit RESP3 "txt" where appropriate. CLIENT INFO should emit Bulkstring in RESP2, not simple. Use this to add final newline to make output easier to read.
… functions to previous RespServerSession.cs file.
…ix a few error messages.
…t specialized functions can be useful.
ACL WHOAMI should return bulk, not simple string. Latency help doesn't accept subarguments.
…ng ASCII, so UTF8 output is pointless. A few more AbortWith.. replacements where there are no performance implications for the main path and the resulting code is clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main goals:
The former is done by fixing various cases for RESP3 null/double and adding verbatim string support. The latter is done by adding output functions to RespServerSession (in a separate file), but the PR holds off on use till performance implications are fully checked. Also some misc. RESP2 updates (redis-cli expects an extra newlines in CLIENT INFO/LIST, these commands should emit Bulk, not simple strings).