Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export AnchorButtonStyles in its index.ts #33957

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: export AnchorButtonStyles in its index.ts #33957

wants to merge 3 commits into from

Conversation

motss
Copy link

@motss motss commented Mar 9, 2025 •
edited
Loading

Previous Behavior

AnchorButtonStyles was not exported, deviating from the standard component style export pattern.

New Behavior

AnchorButtonStyles is now exported, aligning with other components.

Related Issue(s)

N/A

@motss
fix: export AnchorButtonStyles in its index.ts
91a3e6b 
Exporting missing AnchorButtonStyles to make it consistent with other components.
@motss motss marked this pull request as ready for review March 9, 2025 17:09
@motss motss requested a review from a team as a code owner March 9, 2025 17:09
chrisdholt
chrisdholt approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since this technically change the API contract we'll want a change file for this (with prerelease).

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

📊 Bundle size report

✅ No changes found

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@motss
chore: add prerelease change file
97d4285 
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
@motss
Copy link
Author

motss commented Mar 11, 2025

@chrisdholt I've run yarn change and committed a change file. PTAL.

@motss
Copy link
Author

motss commented Mar 11, 2025

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motss @chrisdholt