feat(workspace-plugin): add vrt generator #33942
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
Hotell
force-pushed
the
hotell/fhl-spring-25
branch
3 times, most recently
from
729a629 to
a5d6c4d
Compare
Hotell
reviewed
Mar 11, 2025
| "executor": "@fluentui/workspace-plugin:visual-regression", | ||
| }, | ||
| "test-vr-cli": Object { | ||
| "command": "visual-regression-assert --baselineDir dist/baseline --actualDir dist/screenshots --diffDir dist/diff --reportPath dist/report.html", |
There was a problem hiding this comment.
| */ | ||
| export interface VisualRegressionSchema { | ||
| /** | ||
| * The name of the component package |
There was a problem hiding this comment.
bad copy paste ?
how is this supposed to work ? user provides v9 project ( react-card ) for instance and we create the new visual-regression project ?
There was a problem hiding this comment.
Yes, I thought it to work in the similar way as we have other generators, to have a prompt with dropdown of projects. Is there a better way?
|
|
||
| function normalizeOptions(tree: Tree, options: VisualRegressionSchema) { | ||
| const projectName = `${options.project}-visual-regression`; | ||
| const root = joinPathFragments('packages', 'react-components', options.project, 'visual-regression'); |
There was a problem hiding this comment.
you need to construct this based on const { projectConfig } root
| } | ||
|
|
||
| function normalizeOptions(tree: Tree, options: VisualRegressionSchema) { | ||
| const projectName = `${options.project}-visual-regression`; |
There was a problem hiding this comment.
we need to filter out that user doesnt specify by mistake lets say a react-text-stories project or an application
mainframev
force-pushed
the
fhl-spring-25-vrt-generator
branch
from
8abe6b1 to
3db6d29
Compare
|
VR Regression Report:
|
mainframev
force-pushed
the
fhl-spring-25-vrt-generator
branch
from
3db6d29 to
35bdc7c
Compare
mainframev
force-pushed
the
fhl-spring-25-vrt-generator
branch
from
35bdc7c to
d5f82fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)