Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

high contrast bug fixes #33322

Closed
wants to merge 2 commits into from
+29 −8
Closed

high contrast bug fixes #33322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5cbab8
high contrast bug fixes
Anush2303 Nov 21, 2024
2c7199c
heap out of memory error fix
Anush2303 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions packages/charts/chart-web-components/src/horizontal-bar-chart/horizontal-bar-chart.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
colorNeutralForeground1,
colorNeutralStrokeAccessible,
display,
forcedColorsStylesheetBehavior,
shadow4,
spacingHorizontalL,
spacingHorizontalS,
Expand Down Expand Up @@ -50,17 +51,17 @@ export const styles: ElementStyles = css`
border: 2px;
pointer-events: none;
}
.tooltipline {
.tooltip-line {
padding-inline-start: 8px;
height: 50px;
border-inline-start: 4px solid;
}
.tooltiplegend {
.tooltip-legend-text {
font-size: 13px;
color: theme.semanticColors.bodyText;
text-align: start;
}
.tooltipdata {
.tooltip-data-y {
font-weight: bold;
font-size: 30px;
text-align: start;
Expand Down Expand Up @@ -164,4 +165,22 @@ export const styles: ElementStyles = css`
${typographyBody1StrongStyles}
color: ${colorNeutralForeground1};
}
`;
@media (forced-colors: active) {
.bar-label {
fill: white !important;
}
}
`.withBehaviors(
forcedColorsStylesheetBehavior(css`
.legend-rect,
.tooltip-line,
.triangle {
forced-color-adjust: none;
}
.tooltip-legend-text,
.tooltip-content-y {
forced-color-adjust: auto;
color: rgb(255, 255, 255);
}
`),
);
8 changes: 5 additions & 3 deletions ...ges/charts/chart-web-components/src/horizontal-bar-chart/horizontal-bar-chart.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ export function horizontalbarchartTemplate<T extends HorizontalBarChart>(): Elem
class="tooltip"
style="inset-inline-start: ${x => x.tooltipProps.xPos}px; top: ${x => x.tooltipProps.yPos}px"
>
<div class="tooltipline" style="border-color: ${x => x.tooltipProps.color};">
<div class="tooltiplegend">${x => x.tooltipProps.legend}</div>
<div class="tooltipdata" style="color: ${x => x.tooltipProps.color};">${x => x.tooltipProps.yValue}</div>
<div class="tooltip-line" style="border-color: ${x => x.tooltipProps.color};">
<div class="tooltip-legend-text">${x => x.tooltipProps.legend}</div>
<div class="tooltip-data-y" style="color: ${x => x.tooltipProps.color};">
${x => x.tooltipProps.yValue}
</div>
</div>
</div>
`,
Expand Down
2 changes: 1 addition & 1 deletion packages/fluentui/react-northstar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"clean": "gulp clean:component-info bundle:package:clean",
"lint": "eslint --ext .js,.ts,.tsx .",
"lint:fix": "yarn lint --fix",
"test": "gulp test",
"test": "cross-env NODE_OPTIONS=--max-old-space-size=8192 gulp test",
"test:watch": "gulp test:watch"
},
"sideEffects": false,
Expand Down
Loading