Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: stop click propagation on cell focusable example #33307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: stop click propagation on cell focusable example #33307

wants to merge 1 commit into from
+7 −3

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Nov 20, 2024 •
edited
Loading

Adds stopPropagation to button and button groups in cells to avoid triggering row selection.

Fixes #33262

@ling1726
docs: stop click prpagation on cell focusable example
56d6acb 
Adds stopPropagation to button and button groups in cells to avoid
triggering row selection.

Fixes microsoft#33262
@ling1726 ling1726 marked this pull request as ready for review November 20, 2024 18:14
@ling1726 ling1726 requested a review from a team as a code owner November 20, 2024 18:14
@github-actions GitHub Actions
Copy link

📊 Bundle size report

✅ No changes found

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

bsunderhus
bsunderhus approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@bsunderhus bsunderhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can't we have a internal mechanism to ignore clicks coming from some certain cells instead of stopping their propagations? 🤔🩹

khmakoto
khmakoto approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@khmakoto khmakoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some text to the story description about needing to stop propagation on focusable elements to stop cell selection from changing?

@khmakoto khmakoto mentioned this pull request Nov 21, 2024
Closed
@khmakoto khmakoto changed the title docs: stop click prpagation on cell focusable example docs: stop click propagation on cell focusable example Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
November Project Cycle Q4 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@ling1726 @bsunderhus @khmakoto