update text inside donut based on highlighted arc #33301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
AtishayMsft
reviewed
Nov 20, 2024
| const lineHeight = this._textInsideDonut.getBoundingClientRect().height; | ||
| wrapText(this._textInsideDonut, 2 * this.innerRadius); | ||
| const lines = this._textInsideDonut.getElementsByTagName('tspan'); | ||
| const start = -Math.trunc((lines.length - 1) / 2); |
There was a problem hiding this comment.
This is error prone. Make it -1*Math.trunc
AtishayMsft
reviewed
Nov 20, 2024
| const start = -Math.trunc((lines.length - 1) / 2); | ||
| for (let i = 0; i < lines.length; i++) { | ||
| lines[i].setAttribute('dy', `${(start + i) * lineHeight}`); | ||
| this._textInsideDonut = document.createElementNS(SVG_NAMESPACE_URI, 'text'); |
There was a problem hiding this comment.
can we make this part of the template?
There was a problem hiding this comment.
@krkshitij can u answer this.
There was a problem hiding this comment.
Yes, it can be done. But then all arc paths should be inserted before this text to ensure that the text appears on top when it overflows.
|
Make sure the build, test lint steps are passing by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)