chore(web-components): Switch Storybook framework from html-webpack5 to html-vite #33298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Nov 19, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Left center.chromium.png | 2616 | Changed |
| Callout.Root.chromium.png | 2309 | Changed |
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
📊 Bundle size report
Unchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
radium-v
force-pushed
the
users/radium-v/storybook-vite
branch
from
27ddad7
to
3fc8bfe
Compare
|
Pull request demo site: URL |
fabricteam
reviewed
Nov 19, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 18 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay High Contrast.chromium.png | 2239 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The web-components project uses the
html-webpack5framework for Storybook. This requires a lot of extra configuration overrides to behave how we want it.New Behavior
The web-components project uses the
html-viteframework. This is much faster to build and run, since it enables the use ofesbuildfor TypeScript transpilation. It also provides a smoother upgrade path once the repo updates to Storybook 8.