Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-swatch-picker): fixed colors of selected and pressed states #31830

Merged

Conversation

ValentinaKozlova
Copy link
Contributor

While building UI kit we decided to make selected and pressed states darker.

Previous Behavior

selected hover
image

selected pressed
image

New Behavior

selected hover
image

selected pressed
image

@ValentinaKozlova ValentinaKozlova self-assigned this Jun 26, 2024
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review June 26, 2024 15:19
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner June 26, 2024 15:19
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 614 629 5000
Button mount 311 300 5000
Field mount 1220 1127 5000
FluentProvider mount 761 716 5000
FluentProviderWithTheme mount 78 87 10
FluentProviderWithTheme virtual-rerender 37 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 76 10
MakeStyles mount 970 873 50000
Persona mount 1846 1719 5000
SpinButton mount 1415 1409 5000
SwatchPicker mount 1682 1683 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.094 MB
270.628 kB
1.094 MB
270.664 kB
195 B
36 B
react-swatch-picker
@fluentui/react-swatch-picker - package
103.495 kB
30.046 kB
103.69 kB
30.094 kB
195 B
48 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.141 kB
20.157 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
211.741 kB
60.957 kB
react-components
react-components: FluentProvider & webLightTheme
44.442 kB
14.607 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
104.384 kB
34.782 kB
🤖 This report was generated against b01e5c5e47b6523f525ccefaf9e0208a228cd9ab

@ValentinaKozlova ValentinaKozlova enabled auto-merge (squash) June 27, 2024 14:11
@ValentinaKozlova ValentinaKozlova merged commit da6d450 into microsoft:master Jun 27, 2024
17 of 19 checks passed
@ValentinaKozlova ValentinaKozlova deleted the fix/swatch-picker-states branch June 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants