fix: update internal usage of useModalAttributes to use legacyTrapFocus by default #31801
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smhigley
requested review from
sopranopillow,
khmakoto and
a team
as code owners
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 33 | 32 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 76 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 628 | 609 | 5000 | |
| Button | mount | 299 | 305 | 5000 | |
| Field | mount | 1106 | 1127 | 5000 | |
| FluentProvider | mount | 728 | 698 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 33 | 32 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 76 | 10 | Possible regression |
| MakeStyles | mount | 862 | 860 | 50000 | |
| Persona | mount | 1701 | 1653 | 5000 | |
| SpinButton | mount | 1380 | 1382 | 5000 | |
| SwatchPicker | mount | 1594 | 1662 | 5000 |
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 24, 2024
change/@fluentui-react-datepicker-compat-bc4d1aaa-945e-4107-9a30-34bbb9550319.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-tabster/src/hooks/useModalAttributes.ts
Outdated
Show resolved
Hide resolved
smhigley
changed the title
sopranopillow
approved these changes
Jun 28, 2024
layershifter
approved these changes
Jun 28, 2024
khmakoto
approved these changes
Jun 28, 2024
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The initial decision around whether to use a hard focus trap (i.e. forcing focus back within a modal when it leaves) vs. a soft one (preventing focus from reaching the background page, but allowing it to reach browser controls) was based around where HTML seemed to be going -- both the
dialogelement and theinertattribute allow you to reach the browser chrome.However, both our v9 Dialog and Popover already use the hard focus trap by default now, and user feedback seems to indicate that's preferred anyway. This PR updates
DatePickerto be consistent with Dialog & Popover, and updates theuseModalAttributeshook to also implement a hard focus trap by default. That seems like the best approach for both internal consistency in v9, and for keyboard & screen reader users.