fix(react-icons): properly resolve atoms grouppings if icon contains style variant as part of its name #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
react-icons/fix-text-atom
branch
from
2b79dbf to
ca7c5c7
Compare
Hotell
commented
Jan 23, 2026
| * @returns {string} The normalized base name of the icon. | ||
| * @throws {Error} If the filename does not end with a valid style suffix. | ||
| */ | ||
| function normalizeBaseName(fileName, styleVariants = ICON_STYLE_VARIANTS) { |
Collaborator
Author
There was a problem hiding this comment.
implementation was simplified with proper guards to adhere to valid file patterns from /assets provided by design
Hotell
commented
Jan 23, 2026
| const items = [ | ||
| { exportName: 'Dup20Filled', exportCode: 'export const Dup20Filled = 1;', fileName: 'dup-20-filled.tsx' }, | ||
| { exportName: 'Dup20Filled', exportCode: 'export const Dup20Filled = 2;', fileName: 'dup-20-filled-2.tsx' }, | ||
| { exportName: 'Dup20Filled', exportCode: 'export const Dup20Filled = 2;', fileName: 'dup-22-filled.tsx' }, |
Collaborator
Author
There was a problem hiding this comment.
we had "made up" patterns within test which doesn't exist, aligned now with real contents of /assets
Hotell
commented
Jan 23, 2026
| * @returns {Promise<void>} | ||
| * @throws Will throw an error if potential grouping issues are detected. | ||
| */ | ||
| async function assertCompoundStyleVariantIssues(destPath) { |
Collaborator
Author
There was a problem hiding this comment.
added build last line of defense to double check generated outputs from /assets, will fail build if there are issues
Hotell
commented
Jan 23, 2026
|
|
||
| const deprecatedMsg = `/** @deprecated use from @fluentui/${type}/color import. This was generated for backward compatibility and will be removed in next major release */`; | ||
| const generatedFiles = [] | ||
| const deprecatedMsg = getDeprecatedMsg(type, 'color'); |
Hotell
commented
Jan 23, 2026
| writeSvg('ic_fluent_dup_20.svg', '<svg width="20" d="M0"></svg>'); | ||
| // this variant without underscore will camelCase to the same export name (Dup20) | ||
| writeSvg('ic_fluent_dup20.svg', '<svg width="20" d="M1"></svg>'); | ||
| writeSvg('ic_fluent_dup_20_regular.svg', '<svg width="20" d="M0"></svg>'); |
Collaborator
Author
There was a problem hiding this comment.
updates test to reflect reality of /assets
Hotell
force-pushed
the
react-icons/fix-text-atom
branch
from
5221bdb to
c27b3a8
Compare
mainframev
previously approved these changes
Feb 2, 2026
Hotell
force-pushed
the
react-icons/fix-text-atom
branch
from
c27b3a8 to
5a26eef
Compare
mainframev
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
TextColor<size><variant>exports have been incorrectly groupped with Text undertext.tsxmoduleAfter:
TextColor<size><variants>exports groupped undertext-color.tsxText<size><variant>exports groupped withintext.tsxmodule@deprecationannotationThis fix enables build transforms via swc or babel without additional workarounds as initially documented https://github.com/microsoft/fluentui-system-icons/blob/main/packages/react-icons/README.md#using-api-via-build-transform