Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tree-grid): updates LiveMeetingsList story for better navigation #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Nov 21, 2024

Updates LiveMeetingsList stories to ensure a better narration.

  1. move each information provided on a row for it's own gridcell

@bsunderhus bsunderhus self-assigned this Nov 21, 2024
@bsunderhus bsunderhus marked this pull request as ready for review November 21, 2024 07:35
@bsunderhus bsunderhus requested a review from a team as a code owner November 21, 2024 07:35
Comment on lines +276 to +280
{props.attachments && (
<TreeGridCell className={styles.attachments}>
{props.attachments}
</TreeGridCell>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the conclusion on assymetric rows for treegrids? should we have them or not?

Copy link
Contributor Author

@bsunderhus bsunderhus Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no conclusion, we're focusing at the moment on the proper narration when you navigate on a nested level (from row to cells). At the moment there's a long repetition of unreachable content that is narrated once on the row level and again once you go into the cells, we're trying to mitigate that at the moment.

I believe the asymmetry might be an issue when navigating between rows, on a vertical level, we still need to verify that with more screen readers.

Copy link

@kolaps33 kolaps33 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point I think would be better to render just empty gridcell.

Because when trying to navigation with NVDA in column navigation ctrl+alt+up/down arrows, then when there is asymmetry, then screen reader jump to different column automatically. What sounds to me confusing, because I want to keep column navigation...

This is good point for next discussion how to solve it properly :)
Anyway if we decide to have it symmetric still we need to figure if we should add aria-label "empty" for empty gridcell or let it handle by screen reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants