Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(variant-theme): keep custom colors #261

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

RongqiZ
Copy link
Contributor

@RongqiZ RongqiZ commented Nov 21, 2024

Since color is user's choice, so we will keep the color, and do not flip it when it has contrast issue.

before:
image

after:
image

@RongqiZ RongqiZ requested a review from a team as a code owner November 21, 2024 05:01
@RongqiZ RongqiZ changed the title keep custom colors feat(variant-theme): keep custom colors Nov 21, 2024
@ymyqwe ymyqwe merged commit 369d425 into microsoft:main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants