Handle 405 errors (#3777)

* Handle 405 error * Updated the diagnosticInfo * Added unit test * Updated tests
microsoft · Mar 29, 2024 · ae6128c · ae6128c
1 parent 64d456b
commit ae6128c
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs b/src/Microsoft.Health.Fhir.Api/Resources.Designer.cs
diff --git a/src/Microsoft.Health.Fhir.Api/Resources.resx b/src/Microsoft.Health.Fhir.Api/Resources.resx
@@ -182,6 +182,9 @@
     <value>The requested "{0}" operation is not supported.</value>
     <comment>{0} is the operation name</comment>
   </data>
+  <data name="OperationNotSupported" xml:space="preserve">
+    <value>The requested operation is not supported.</value>
+  </data>
   <data name="PageTitle" xml:space="preserve">
     <value>FHIR Server</value>
     <comment>{NumberedPlaceHolder="FHIR"}</comment>

diff --git a/src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs b/src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs
@@ -126,6 +126,11 @@ public IActionResult CustomError(int? statusCode = null)
                     returnCode = HttpStatusCode.NotFound;
                     diagnosticInfo = Resources.NotFoundException;
                     break;
+                case (int)HttpStatusCode.MethodNotAllowed:
+                    issueType = OperationOutcome.IssueType.NotSupported;
+                    returnCode = HttpStatusCode.MethodNotAllowed;
+                    diagnosticInfo = Resources.OperationNotSupported;
+                    break;
                 default:
                     issueType = OperationOutcome.IssueType.Exception;
                     returnCode = HttpStatusCode.InternalServerError;

diff --git a/test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/ExceptionTests.cs b/test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/ExceptionTests.cs
@@ -5,6 +5,7 @@
 
 using System;
 using System.Net;
+using System.Net.Http;
 using Hl7.Fhir.Model;
 using Hl7.Fhir.Validation;
 using Microsoft.AspNetCore.Builder;
@@ -102,6 +103,18 @@ public async Task GivenAnUnknownRoute_WhenPostingToHttp_TheServerShouldReturnAnO
             DotNetAttributeValidation.Validate(operationOutcome, true);
         }
 
+        [Fact]
+        [Trait(Traits.Priority, Priority.One)]
+        public async Task GivenANotAllowedMethod_WhenRequestIsSent_TheServerShouldReturnMethodNotSupported()
+        {
+            using var requestMessage = new HttpRequestMessage();
+            string uriString = _client.HttpClient.BaseAddress + "admin.html";
+            requestMessage.RequestUri = new Uri(uriString);
+            requestMessage.Method = HttpMethod.Head;
+            HttpResponseMessage response = await _client.HttpClient.SendAsync(requestMessage);
+            Assert.Equal(HttpStatusCode.MethodNotAllowed, response.StatusCode);
+        }
+
         public class StartupWithThrowingMiddleware : StartupBaseForCustomProviders
         {
             public StartupWithThrowingMiddleware(IConfiguration configuration)