Expanded certain unit tests to run for native programs #4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmlud21
force-pushed
the
clean-issue4261
branch
from
196708b to
7e9560b
Compare
nmlud21
force-pushed
the
clean-issue4261
branch
from
229b450 to
bd8e839
Compare
nmlud21
requested review from
Alan-Jowett,
LakshK98,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
dthaler
reviewed
Sep 26, 2025
nmlud21
force-pushed
the
clean-issue4261
branch
2 times, most recently
from
ce77c22 to
14c75e9
Compare
Formatting changes Rewrote more tests to run for all eBPF programs. Modified certain tests to run for all types of eBPF programs. Modified specific netsh_test to include all eBPF program types. Added a scope exit to ensure cleanup during fault injection. Reordered cleanup in test helper destructor.
nmlud21
force-pushed
the
clean-issue4261
branch
from
14c75e9 to
d49e78f
Compare
dthaler
approved these changes
Oct 1, 2025
Collaborator
dthaler
left a comment
dthaler
left a comment
There was a problem hiding this comment.
Approving since my remaining comment is not a big deal either way.
If you need to rev this again for some other reason, would be good to address.
But ok with me to merge if someone else approves it as is.
Comment on lines
+133
to
+147
| #if !defined(CONFIG_BPF_JIT_DISABLED) | ||
| void | ||
| test_invalid_bpf_action(char log_buffer[]) | ||
| { | ||
| REQUIRE(errno == EACCES); | ||
| REQUIRE(strcmp(log_buffer, "0: Invalid type (r0.type == number)\n\n") == 0); | ||
| } | ||
| #else | ||
| void | ||
| test_invalid_bpf_action(char log_buffer[]) | ||
| { | ||
| UNREFERENCED_PARAMETER(log_buffer); | ||
| REQUIRE(errno == ENOTSUP); | ||
| } | ||
| #endif |
Collaborator
There was a problem hiding this comment.
This is ok, but since lines 135, 136, and 139 are the same as 142, 143, and 146, it would seem better to me to put the ifdefs inside the function, only wrapping the two different lines.
Alan-Jowett
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4261
Some tests in libbpf_test.cpp and netsh_test.cpp only ran for JIT/Interpreted programs. Some of these tests should also run for native programs so for each applicable test, functionality was expanded so that the test would also run for native eBPF programs.
Testing
No new tests needed.
Documentation
No.
Installation
No.