Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Docker Hub references with GitHub references #1177

Merged
merged 16 commits into from
Oct 2, 2024

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Oct 2, 2024

Fixes #1176

This PR contains the following changes:

  1. Replaced the Docker Hub references with Github except for in the Docker Hub readmes and a few select links that specific to Docker Hub (e.g. the official docker hub images).
  2. Updated the Windows base image license to be identical to dotnet-docker. This was necessary as the template logic was calling into the URL formatting template and special casing this would have been difficult.
  3. Updated the supported-tags documentation to be more like dotnet-docker in a few areas as a way to eliminate docker hub links.
  4. Removed the trailing '/' in the links to the MCR about pages. This makes this repo consistent with dotnet-docker. This was a result of porting the URL formatting template from dotnet-docker

@MichaelSimons MichaelSimons marked this pull request as ready for review October 2, 2024 18:10
eng/readme-templates/Support.md Outdated Show resolved Hide resolved
documentation/supported-tags.md Outdated Show resolved Hide resolved
documentation/supported-tags.md Outdated Show resolved Hide resolved
documentation/supported-tags.md Outdated Show resolved Hide resolved
samples/README.md Outdated Show resolved Hide resolved
samples/aspnetmvcapp/README.md Outdated Show resolved Hide resolved
@MichaelSimons
Copy link
Member Author

Merging ahead of CI as remaining legs are not affected by documentation changes.

@MichaelSimons MichaelSimons merged commit 5639e04 into microsoft:main Oct 2, 2024
4 of 11 checks passed
@MichaelSimons MichaelSimons deleted the hub.docker.remove branch October 2, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop referencing Docker Hub repos in GitHub readmes and documentation
3 participants