chore: dev to main merge#863
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates e2e test configuration and the Start Over validation flow to improve reliability and align the sample environment file with the test constants.
Changes:
- Increased the Start Over button visibility timeout.
- Simplified and renumbered the Start Over e2e test flow.
- Updated the sample
.envvariable name to match test configuration usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/e2e-test/tests/test_content_gen_gp_tc.py |
Simplifies Start Over test steps and timing labels. |
tests/e2e-test/sample_dotenv_file.txt |
Updates the sample URL environment variable to url. |
tests/e2e-test/pages/HomePage.py |
Extends the Start Over button wait timeout to reduce flakiness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Avijit-Microsoft
approved these changes
Jun 1, 2026
Roopan-Microsoft
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes several updates to the end-to-end tests to improve reliability and clarity, particularly around the "Start Over" functionality. The main changes include increasing the timeout for the start over button, updating test step descriptions and timing, and standardizing environment variable naming.
Test reliability improvements:
START_OVER_BUTTONto become visible from 10 seconds to 30 seconds inHomePage.py, reducing test flakiness in slower environments.Test clarity and maintenance:
test_validate_start_overby removing unnecessary steps and updating the step description to focus only on clicking "Start over" and validating the displayed text.test_validate_start_overto match the updated step numbering, improving test log clarity.Configuration consistency:
sample_dotenv_file.txtfromMACAE_WEB_URLtourlfor consistency and simplicity.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation