Adopt MSVC 14.50 and fix C4874 assignment-as-condition in Grapher.cpp#2436
Open
michaelbprice wants to merge 1 commit intomicrosoft:mainfrom
Open
Adopt MSVC 14.50 and fix C4874 assignment-as-condition in Grapher.cpp#2436michaelbprice wants to merge 1 commit intomicrosoft:mainfrom
michaelbprice wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…6 to extract assignment before condition check - Resolves C2220/C4874 build error - Fixes cascading build failures - Solution builds with 0 errors - Includes project retargeting to v145
a61bde1 to
bf9cf4d
Compare
Author
|
I did a force push to correct a mistake I made with my commits. The original commit included the Copilot markdown files. I had amended that commit to remove them, but then didn't reset my working branch correctly to that commit. It is now corrected. |
Author
|
It looks like the build fails because the runner being used doesn't have Visual Studio 2026 and MSVC 14.50 installed on it. Feel free to keep this PR around until that's resolved, or cancel and I can resubmit it at a later time. OR we could just pull out the warning fix, as it is valid for v143 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2360.
cppbuildtoolsupgrade_01921b.zip
Description of the changes:
How changes were validated:
I was unable to successfully run the CalculatorUITests locally. After getting WinAppDriver installed and Developer Mode settings adjusted, it gave me an error
I received a similar error when trying to run the CalculatorUnitTests project, but these were dialog popups, not exceptions listed in Test Explorer.
The changes are trivial, but should be tested by someone with that capability before merging.
These changes were made by GitHub Copilot app modernization for C++, which is now in public preview. I am attaching a .zip file with the generated Markdown files laying out the analysis, plan, tasks, and execution summary, in case you want to examine Copilot's "reasoning" on the issues discovered.
It also diagnosed the deprecated
/awaitswitch as mentioned in #2404, but I instructed Copilot to not resolve those warnings as a part of this effort.